JSON datatype support #2558
Open
JSON datatype support #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2558 +/- ##
============================================
- Coverage 51.01% 50.09% -0.93%
+ Complexity 3921 3829 -92
============================================
Files 147 147
Lines 33483 33544 +61
Branches 5609 5619 +10
============================================
- Hits 17081 16803 -278
- Misses 13991 14347 +356
+ Partials 2411 2394 -17 ☔ View full report in Codecov by Sentry. |
machavan
reviewed
Dec 19, 2024
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/RegressionTest.java
Show resolved
Hide resolved
|
/azp run public-mssql-jdbc.windows |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
No pipelines are associated with this pull request. |
|
/azp run public-mssql-jdbc.linux |
|
/azp run CI-MacOS |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
divang
commented
Jan 3, 2025
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableStatementTest.java
Outdated
Show resolved
Hide resolved
…m/microsoft/mssql-jdbc into user/divang/json-datatype-support
Jeffery-Wasty
requested review from
lilgreenbird,
Jeffery-Wasty,
Ananya2,
tkyc,
muskan124947,
machavan and
Copilot
There was a problem hiding this comment.
Copilot reviewed 11 out of 26 changed files in this pull request and generated no comments.
Files not reviewed (15)
- src/main/java/com/microsoft/sqlserver/jdbc/SQLServerResource.java: Evaluated as low risk
- src/main/java/com/microsoft/sqlserver/jdbc/Parameter.java: Evaluated as low risk
- src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/BulkCopyCSVTest.java: Evaluated as low risk
- src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDataTable.java: Evaluated as low risk
- src/main/java/com/microsoft/sqlserver/jdbc/Column.java: Evaluated as low risk
- src/main/java/com/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java: Evaluated as low risk
- src/main/java/com/microsoft/sqlserver/jdbc/IOBuffer.java: Evaluated as low risk
- src/main/java/com/microsoft/sqlserver/jdbc/SQLServerResultSetMetaData.java: Evaluated as low risk
- src/main/java/com/microsoft/sqlserver/jdbc/DataTypes.java: Evaluated as low risk
- src/test/java/com/microsoft/sqlserver/jdbc/bulkCopy/SqlTypeMapping.java: Evaluated as low risk
- src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java: Evaluated as low risk
- src/main/java/microsoft/sql/Types.java: Evaluated as low risk
- src/main/java/com/microsoft/sqlserver/jdbc/dtv.java: Evaluated as low risk
- src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableStatementTest.java: Evaluated as low risk
- src/test/java/com/microsoft/sqlserver/jdbc/tvp/TVPTypesTest.java: Evaluated as low risk
…using the column label instead of the index.
src/test/java/com/microsoft/sqlserver/jdbc/JSONFunctionTest.java
Outdated
Show resolved
Hide resolved
David-Engel
reviewed
Feb 20, 2025
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerBulkCSVFileRecord.java
Outdated
Show resolved
Hide resolved
…otes, preventing misclassification of non-JSON braces, and adding test cases based on review comments.
…mnNameWithJson.csv.
…al and local temporary tables, UDF with SELECT, WHERE, and FROM clauses, and SELECT INTO queries.
…ata check, direct function call validation, and assertion for JSON structure.
…BulkCopy=true in connection string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To add support for the new JSON datatype, the following changes have been made to the codebase: